Skip to content

Comments

client: expose resource cleanup methods#444

Merged
ParthSareen merged 4 commits intomainfrom
parth/client-resource-cleanup
Dec 11, 2025
Merged

client: expose resource cleanup methods#444
ParthSareen merged 4 commits intomainfrom
parth/client-resource-cleanup

Conversation

@ParthSareen
Copy link
Member

@ParthSareen ParthSareen commented Feb 13, 2025 •
edited
Loading

  • added support for context manager protocol
  • added explicit .close() method to manage clients

Previously a ResourceWarning was getting thrown:

<sys>:0: ResourceWarning: unclosed <socket.socket fd=3, family=2, type=1, proto=6, laddr=('127.0.0.1', 57073), raddr=('127.0.0.1', 11434)>

This can now be prevented with the client.close() method or by using Python's context manager protocol.
Users can now also use client with context manager protocol as:

with Client() as client:
    messages = [
      {
        'role': 'user',
        'content': 'Why is the sky blue?',
      },
    ]

    response = client.chat('llama3.2', messages=messages)
    print(response['message']['content'])

Closes: #441

mxyng
mxyng reviewed Feb 14, 2025
View reviewed changes
@ParthSareen ParthSareen force-pushed the parth/client-resource-cleanup branch from 37c7817 to 1a047b0 Compare February 14, 2025 06:28
@ParthSareen ParthSareen force-pushed the parth/client-resource-cleanup branch from 71ffad6 to 39d515f Compare December 10, 2025 23:27
@ParthSareen ParthSareen merged commit d1d7040 into main Dec 11, 2025
2 checks passed
@ParthSareen ParthSareen deleted the parth/client-resource-cleanup branch December 11, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxyng mxyng mxyng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to close connections

2 participants

@ParthSareen @mxyng